From ff0bced09f91d0698c8a9b2b3c3c0b885cdff7e0 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Tue, 14 Mar 2017 18:20:27 +0100 Subject: [PATCH] x86emul: correct {,v}{ld,st}mxcsr handling Calls to get_fpu() were missing. Calls to put_fpu() are deliberately not being added: Neither instruction can raise #XM, so the catch-all _put_fpu() is just fine here. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- xen/arch/x86/x86_emulate/x86_emulate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index 0cbeb31db4..4872f19c5d 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -6509,6 +6509,7 @@ x86_emulate( vcpu_must_have(sse); ldmxcsr: generate_exception_if(src.type != OP_MEM, EXC_UD); + get_fpu(vex.opcx ? X86EMUL_FPU_ymm : X86EMUL_FPU_xmm, &fic); generate_exception_if(src.val & ~mxcsr_mask, EXC_GP, 0); asm volatile ( "ldmxcsr %0" :: "m" (src.val) ); break; @@ -6518,6 +6519,7 @@ x86_emulate( vcpu_must_have(sse); stmxcsr: generate_exception_if(dst.type != OP_MEM, EXC_UD); + get_fpu(vex.opcx ? X86EMUL_FPU_ymm : X86EMUL_FPU_xmm, &fic); asm volatile ( "stmxcsr %0" : "=m" (dst.val) ); break; -- 2.30.2