From fcacf69f3b07e23e91c6c555968f06d25563fbdf Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9my=20Lal?= Date: Mon, 10 Feb 2025 15:45:36 +0100 Subject: [PATCH] adapt test-ci build target for buildd Forwarded: not-needed Reviewed-By: Xavier Guimard Last-Update: 2020-02-09 * log to stdout * increase timeout multipliers Gbp-Pq: Topic build Gbp-Pq: Name test_ci.patch --- Makefile | 2 +- test/common/index.js | 15 +++++++-------- test/sequential/sequential.status | 2 +- tools/test.py | 3 ++- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Makefile b/Makefile index 8b38de278..10995016e 100644 --- a/Makefile +++ b/Makefile @@ -558,7 +558,7 @@ test-ci-native: | benchmark/napi/.buildstamp test/addons/.buildstamp test/js-nat # This target should not use a native compiler at all # Related CI job: node-test-commit-arm-fanned test-ci-js: | clear-stalled - $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \ + $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap \ --mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \ --skip-tests=$(CI_SKIP_TESTS) \ $(TEST_CI_ARGS) $(CI_JS_SUITES) diff --git a/test/common/index.js b/test/common/index.js index c39488dd0..5bd2e3ba6 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -278,16 +278,15 @@ const pwdCommand = isWindows ? function platformTimeout(ms) { const multipliers = typeof ms === 'bigint' ? - { two: 2n, four: 4n, seven: 7n } : { two: 2, four: 4, seven: 7 }; + { fast: 2n, slow: 4n } : { fast: 3, slow: 5 }; + + if (process.arch.startsWith('arm') || process.arch.startsWith('mips') || process.arch.startsWith('riscv')) + ms = multipliers.slow * ms; + else + ms = multipliers.fast * ms; if (process.features.debug) - ms = multipliers.two * ms; - - if (exports.isAIX || exports.isIBMi) - return multipliers.two * ms; // Default localhost speed is slower on AIX - - if (isPi) - return multipliers.two * ms; // Raspberry Pi devices + ms = multipliers.slow * ms; return ms; } diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status index dd2275ddc..343226457 100644 --- a/test/sequential/sequential.status +++ b/test/sequential/sequential.status @@ -8,7 +8,7 @@ prefix sequential # https://github.com/nodejs/node/issues/27611#issuecomment-613100468 test-cpu-prof-dir-worker: PASS, FLAKY # https://github.com/nodejs/node/issues/44898 -test-watch-mode: PASS, FLAKY +test-watch-mode: SKIP test-watch-mode-inspect: PASS, FLAKY # https://github.com/nodejs/node/issues/47409 test-http2-large-file: PASS, FLAKY diff --git a/tools/test.py b/tools/test.py index 9d7838d7c..79417f6bb 100755 --- a/tools/test.py +++ b/tools/test.py @@ -1762,7 +1762,8 @@ def Main(): def should_keep(case): if any((s in case.file) for s in options.skip_tests): - return False + case.outcomes.add(FLAKY) + return True elif SKIP in case.outcomes: return False elif (options.flaky_tests == SKIP) and (set([SLOW, FLAKY]) & case.outcomes): -- 2.30.2