From fc7a9f7be97f6ece1e6507f1ee43c841dc3ecfc6 Mon Sep 17 00:00:00 2001 From: Don Slutz Date: Fri, 2 May 2014 16:18:05 -0400 Subject: [PATCH] hvm/hpet: Init comparator64 like comparator. The software-developers-hpet-spec-1-0a.pdf says that the comparator starts as all 1's. Also make the hidden register comparator64 the same. Since only the hidden register comparator64 is used by hpet_save, it needs to start out with the right value. A disabled hpet (like when a guest is starting), should start with the value the spec says. Both the guest (via reading the comparator) and an administrator using xen-hvmctx, will see all 0's not all 1's. Signed-off-by: Don Slutz Acked-by: Jan Beulich Acked-by: Tim Deegan --- xen/arch/x86/hvm/hpet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c index b6113041cd..741fb7ae9d 100644 --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -636,6 +636,7 @@ void hpet_init(struct vcpu *v) h->hpet.timers[i].config = HPET_TN_INT_ROUTE_CAP | HPET_TN_64BIT_CAP | HPET_TN_PERIODIC_CAP; h->hpet.timers[i].cmp = ~0ULL; + h->hpet.comparator64[i] = ~0ULL; h->pt[i].source = PTSRC_isa; } } -- 2.30.2