From f827ab0390625cff1f20ee5e140605e173238e81 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roger=20Pau=20Monn=C3=A9?= Date: Fri, 17 Feb 2017 16:10:28 +0100 Subject: [PATCH] build: enable no-parentheses in clang MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit And fix the following errors reported: traps.c:2014:25: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] else if ( (port == RTC_PORT(0)) ) ~~~~~^~~~~~~~~~~~~~ traps.c:2014:25: note: remove extraneous parentheses around the comparison to silence this warning else if ( (port == RTC_PORT(0)) ) ~ ^ ~ traps.c:2014:25: note: use '=' to turn this equality comparison into an assignment else if ( (port == RTC_PORT(0)) ) ^~ = traps.c:2083:25: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] else if ( (port == RTC_PORT(0)) ) ~~~~~^~~~~~~~~~~~~~ Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper --- Config.mk | 3 --- xen/arch/x86/traps.c | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Config.mk b/Config.mk index bff4dc5584..9a28d15a9d 100644 --- a/Config.mk +++ b/Config.mk @@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes -# Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -CFLAGS-$(clang) += -Wno-parentheses - $(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wdeclaration-after-statement) $(call cc-option-add,CFLAGS,CC,-Wdeclaration-after-statement) $(call cc-option-add,CFLAGS,CC,-Wno-unused-but-set-variable) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index ae4a8fa636..ec8b002f6e 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -2010,7 +2010,7 @@ uint32_t guest_io_read(unsigned int port, unsigned int bytes, { sub_data = pv_pit_handler(port, 0, 0); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { sub_data = currd->arch.cmos_idx; } @@ -2079,7 +2079,7 @@ void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, { pv_pit_handler(port, (uint8_t)data, 1); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { currd->arch.cmos_idx = data; } -- 2.30.2