From f707a43b3cff0491ac5b0428d0e18a3aa3fa2db3 Mon Sep 17 00:00:00 2001 From: Olivier Goffart Date: Fri, 28 Jul 2017 10:13:07 +0200 Subject: [PATCH] FolderWizard: fix crash in FolderWizardRemotePath::slotHandleLsColNetworkError The Job is a LsColJob, not a MkColJob! Reproduce by entering a name with invalid character that cause an error 400 in the folder wizard's remote path line edit. (Relates issue #5924) --- src/gui/folderwizard.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gui/folderwizard.cpp b/src/gui/folderwizard.cpp index 940cf8b3a..168f60d88 100644 --- a/src/gui/folderwizard.cpp +++ b/src/gui/folderwizard.cpp @@ -22,6 +22,7 @@ #include "accountstate.h" #include "creds/abstractcredentials.h" #include "wizard/owncloudwizard.h" +#include "asserts.h" #include #include @@ -229,7 +230,8 @@ void FolderWizardRemotePath::slotHandleMkdirNetworkError(QNetworkReply *reply) void FolderWizardRemotePath::slotHandleLsColNetworkError(QNetworkReply * /*reply*/) { - auto job = qobject_cast(sender()); + auto job = qobject_cast(sender()); + ASSERT(job); showWarn(tr("Failed to list a folder. Error: %1") .arg(job->errorStringParsingBody())); } -- 2.30.2