From ebc5fade17d61dcb042df3047ed2b4135b506ddb Mon Sep 17 00:00:00 2001 From: Matthieu Gallien Date: Fri, 3 Feb 2023 18:55:52 +0100 Subject: [PATCH] initialize all variables done with clang-tidy run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-init-variables' -fix Signed-off-by: Matthieu Gallien --- src/3rdparty/kirigami/wheelhandler.cpp | 4 ++-- src/gui/cloudproviders/cloudprovidermanager.cpp | 2 +- src/gui/cloudproviders/cloudproviderwrapper.cpp | 12 ++++++------ test/teste2efiletransfer.cpp | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/3rdparty/kirigami/wheelhandler.cpp b/src/3rdparty/kirigami/wheelhandler.cpp index 9dacae4db..7821b64f9 100644 --- a/src/3rdparty/kirigami/wheelhandler.cpp +++ b/src/3rdparty/kirigami/wheelhandler.cpp @@ -351,8 +351,8 @@ bool WheelHandler::scrollFlickable(QPointF pixelDelta, QPointF angleDelta, Qt::K const qreal xTicks = angleDelta.x() / 120; const qreal yTicks = angleDelta.y() / 120; - qreal xChange; - qreal yChange; + qreal xChange = NAN; + qreal yChange = NAN; bool scrolled = false; // Scroll X diff --git a/src/gui/cloudproviders/cloudprovidermanager.cpp b/src/gui/cloudproviders/cloudprovidermanager.cpp index 8f632c18e..35ff2a5c8 100644 --- a/src/gui/cloudproviders/cloudprovidermanager.cpp +++ b/src/gui/cloudproviders/cloudprovidermanager.cpp @@ -26,7 +26,7 @@ CloudProvidersProviderExporter *_providerExporter; void on_name_acquired (GDBusConnection *connection, const gchar *name, gpointer user_data) { Q_UNUSED(name); - CloudProviderManager *self; + CloudProviderManager *self = nullptr; self = static_cast(user_data); _providerExporter = cloud_providers_provider_exporter_new(connection, LIBCLOUDPROVIDERS_DBUS_BUS_NAME, LIBCLOUDPROVIDERS_DBUS_OBJECT_PATH); cloud_providers_provider_exporter_set_name (_providerExporter, APPLICATION_NAME); diff --git a/src/gui/cloudproviders/cloudproviderwrapper.cpp b/src/gui/cloudproviders/cloudproviderwrapper.cpp index 04ae01c85..bbf65876b 100644 --- a/src/gui/cloudproviders/cloudproviderwrapper.cpp +++ b/src/gui/cloudproviders/cloudproviderwrapper.cpp @@ -34,8 +34,8 @@ GSimpleActionGroup *actionGroup = nullptr; CloudProviderWrapper::CloudProviderWrapper(QObject *parent, Folder *folder, int folderId, CloudProvidersProviderExporter* cloudprovider) : QObject(parent) , _folder(folder) { - GMenuModel *model; - GActionGroup *action_group; + GMenuModel *model = nullptr; + GActionGroup *action_group = nullptr; QString accountName = QString("Folder/%1").arg(folderId); _cloudProvider = CLOUD_PROVIDERS_PROVIDER_EXPORTER(cloudprovider); @@ -147,7 +147,7 @@ void CloudProviderWrapper::slotUpdateProgress(const QString &folder, const Progr if (!progress._lastCompletedItem.isEmpty() && shouldShowInRecentsMenu(progress._lastCompletedItem)) { - GMenuItem* item; + GMenuItem* item = nullptr; g_menu_remove_all (G_MENU(_recentMenu)); if(!_recentlyChanged.isEmpty()) { QList>::iterator i; @@ -208,8 +208,8 @@ void CloudProviderWrapper::slotSyncFinished(const SyncResult &result) GMenuModel* CloudProviderWrapper::getMenuModel() { - GMenu* section; - GMenuItem* item; + GMenu* section = nullptr; + GMenuItem* item = nullptr; QString item_label; _mainMenu = g_menu_new(); @@ -314,7 +314,7 @@ activate_action_pause (GSimpleAction *action, { Q_UNUSED(parameter); auto *self = static_cast(user_data); - GVariant *old_state, *new_state; + GVariant *old_state = nullptr, *new_state = nullptr; old_state = g_action_get_state (G_ACTION (action)); new_state = g_variant_new_boolean (!(bool)g_variant_get_boolean (old_state)); diff --git a/test/teste2efiletransfer.cpp b/test/teste2efiletransfer.cpp index 1722b026c..aa6008a6a 100644 --- a/test/teste2efiletransfer.cpp +++ b/test/teste2efiletransfer.cpp @@ -41,7 +41,7 @@ private slots: { { EndToEndTestHelper _helper; - OCC::Folder *_testFolder; + OCC::Folder *_testFolder = nullptr; QSignalSpy accountReady(&_helper, &EndToEndTestHelper::accountReady); _helper.startAccountConfig(); -- 2.30.2