From e93972824daf18f6d8fff897cd3ca3fd5984685f Mon Sep 17 00:00:00 2001 From: Olivier Goffart Date: Tue, 7 Aug 2018 09:50:55 +0200 Subject: [PATCH] MSI: Fix crash in the auto updater 'auto' here is a QStringBuilder referencing a temporary Ammend commit 150d4f5935c9480cae0a84506af4efa940b64095 (MSI: Always with logfile #6609) Found in the crash reporter: https://sentry.io/owncloud/desktop-win-and-mac/issues/623245771/ --- src/gui/updater/ocupdater.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gui/updater/ocupdater.cpp b/src/gui/updater/ocupdater.cpp index 62514a5ce..b55e73ee5 100644 --- a/src/gui/updater/ocupdater.cpp +++ b/src/gui/updater/ocupdater.cpp @@ -208,7 +208,7 @@ void OCUpdater::slotStartInstaller() return QDir::toNativeSeparators(path); }; - auto msiLogFile = cfg.configPath() + "msi.log"; + QString msiLogFile = cfg.configPath() + "msi.log"; QString command = QString("&{msiexec /norestart /passive /i '%1' /L*V '%2'| Out-Null ; &'%3'}") .arg(preparePathForPowershell(updateFile)) .arg(preparePathForPowershell(msiLogFile)) -- 2.30.2