From e8e9f4b9820fd48bcb0bcb5b7c655224fd71173d Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 2 Sep 2019 14:45:57 +0200 Subject: [PATCH] x86: shrink video_{flags,mode} to {8,16} bits We really don't need them to be any wider. Also remove the C level declaration (and hence also the GLOBAL) of video_mode altogether; it's used in assembly code only. Suggested-by: Andrew Cooper Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- xen/arch/x86/boot/wakeup.S | 5 ++--- xen/include/asm-x86/config.h | 4 +++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/boot/wakeup.S b/xen/arch/x86/boot/wakeup.S index 65ecd0300c..25ec2fa32b 100644 --- a/xen/arch/x86/boot/wakeup.S +++ b/xen/arch/x86/boot/wakeup.S @@ -82,10 +82,9 @@ bogus_real_magic: .align 4 real_magic: .long 0x12345678 -GLOBAL(video_mode) - .long 0 +video_mode: .word 0 GLOBAL(video_flags) - .long 0 + .byte 0 .code32 diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h index 22dc795eea..4370c2aff2 100644 --- a/xen/include/asm-x86/config.h +++ b/xen/include/asm-x86/config.h @@ -99,7 +99,9 @@ extern char trampoline_realmode_entry[]; extern unsigned int trampoline_xen_phys_start; extern unsigned char trampoline_cpu_started; extern char wakeup_start[]; -extern unsigned int video_mode, video_flags; + +extern unsigned char video_flags; + extern unsigned short boot_edid_caps; extern unsigned char boot_edid_info[128]; #endif -- 2.30.2