From e2df19bc3afaa6c3d4842ee97672661b5aa3ad97 Mon Sep 17 00:00:00 2001 From: Ben Hutchings Date: Thu, 19 Jul 2018 23:36:52 +0100 Subject: [PATCH] tools/lib/api/fs/fs.c: Fix misuse of strncpy() gcc 8 reports: In function 'fs__env_override', inlined from 'fs__get_mountpoint' at fs/fs.c:228:6: fs/fs.c:222:2: error: 'strncpy' specified bound 4096 equals destination size [-Werror=stringop-truncation] strncpy(fs->path, override_path, sizeof(fs->path)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I'm not convinced it makes sense to truncate the copied string here, but since we're already doing so let's ensure it's still null- terminated. Use strlcpy() instead. Signed-off-by: Ben Hutchings Gbp-Pq: Topic bugfix/all Gbp-Pq: Name tools-lib-api-fs-fs.c-fix-misuse-of-strncpy.patch --- tools/lib/api/fs/fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c index 7aba8243a0e..52cad933e8a 100644 --- a/tools/lib/api/fs/fs.c +++ b/tools/lib/api/fs/fs.c @@ -12,6 +12,7 @@ #include #include #include +#include #include "fs.h" #include "debug-internal.h" @@ -219,7 +220,7 @@ static bool fs__env_override(struct fs *fs) return false; fs->found = true; - strncpy(fs->path, override_path, sizeof(fs->path)); + strlcpy(fs->path, override_path, sizeof(fs->path)); return true; } -- 2.30.2