From e25fc4cba8439c068a05f29531811cba71069837 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 18 Sep 2017 12:31:02 +0200 Subject: [PATCH] x86emul: re-order checks in test harness On older systems printing the "n/a" messages (resulting from the compiler not being new enough to deal with some of the test code) isn't very useful: If both CPU and compiler are too old for a certain test, we can as well omit those messages, as those tests wouldn't be run even if the compiler did produce code. (This has become obvious with the 3DNow! tests, which I had to run on an older system still supporting those insns, and that system naturally also had an older compiler.) Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- tools/tests/x86_emulator/test_x86_emulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/tests/x86_emulator/test_x86_emulator.c b/tools/tests/x86_emulator/test_x86_emulator.c index 76665abda5..4371e467e6 100644 --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -3019,15 +3019,15 @@ int main(int argc, char **argv) for ( j = 0; j < ARRAY_SIZE(blobs); j++ ) { + if ( blobs[j].check_cpu && !blobs[j].check_cpu() ) + continue; + if ( !blobs[j].size ) { printf("%-39s n/a\n", blobs[j].name); continue; } - if ( blobs[j].check_cpu && !blobs[j].check_cpu() ) - continue; - memcpy(res, blobs[j].code, blobs[j].size); ctxt.lma = blobs[j].bitness == 64; ctxt.addr_size = ctxt.sp_size = blobs[j].bitness; -- 2.30.2