From e2066b317bcd71e683c3dbd315ea5afe95a2003b Mon Sep 17 00:00:00 2001 From: XNG Date: Sun, 23 Feb 2020 10:04:56 +0800 Subject: [PATCH] Disable http2 for now due to Qt bug So that user may continue to use http2 on their webpage Signed-off-by: XNG (cherry picked from commit dad95d4e4617211360bf2b4391e29c341e939844) Signed-off-by: Michael Schuster --- src/libsync/accessmanager.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libsync/accessmanager.cpp b/src/libsync/accessmanager.cpp index 26f392698..6564ae0c8 100644 --- a/src/libsync/accessmanager.cpp +++ b/src/libsync/accessmanager.cpp @@ -93,12 +93,12 @@ QNetworkReply *AccessManager::createRequest(QNetworkAccessManager::Operation op, qInfo(lcAccessManager) << op << verb << newRequest.url().toString() << "has X-Request-ID" << requestId; newRequest.setRawHeader("X-Request-ID", requestId); -#if QT_VERSION >= QT_VERSION_CHECK(5, 9, 4) - // only enable HTTP2 with Qt 5.9.4 because old Qt have too many bugs (e.g. QTBUG-64359 is fixed in >= Qt 5.9.4) + + // Disable http2 for now due to Qt bug if (newRequest.url().scheme() == "https") { // Not for "http": QTBUG-61397 - newRequest.setAttribute(QNetworkRequest::HTTP2AllowedAttribute, true); + newRequest.setAttribute(QNetworkRequest::HTTP2AllowedAttribute, false); } -#endif + return QNetworkAccessManager::createRequest(op, newRequest, outgoingData); } -- 2.30.2