From de4ae7cb9c4abab03186134affeb91526c6fe3fd Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Thu, 20 Jul 2023 19:33:48 +0800 Subject: [PATCH] Fix testing of sync result error activities in sorted activity list test Signed-off-by: Claudio Cambra --- test/testsortedactivitylistmodel.cpp | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/test/testsortedactivitylistmodel.cpp b/test/testsortedactivitylistmodel.cpp index 9614a7730..90b8d74c8 100644 --- a/test/testsortedactivitylistmodel.cpp +++ b/test/testsortedactivitylistmodel.cpp @@ -67,6 +67,21 @@ public: QCOMPARE(model->rowCount(), originalRowCount + 1); } + void addActivity(QSharedPointer model, + void (OCC::ActivityListModel::*addingMethod)(const OCC::Activity &, OCC::ActivityListModel::ErrorType), + OCC::Activity &activity, + OCC::ActivityListModel::ErrorType type) + { + const auto originalRowCount = model->rowCount(); + const auto sourceModel = dynamic_cast(model->sourceModel()); + + (sourceModel->*addingMethod)(activity, type); + QCOMPARE(model->rowCount(), originalRowCount + 1); + + const auto index = model->index(0, 0); + QVERIFY(index.isValid()); + } + private slots: void initTestCase() { @@ -125,7 +140,7 @@ private slots: addActivity(model, &TestingALM::addSyncFileItemToActivityList, testSyncFileItemActivity); addActivity(model, &TestingALM::addNotificationToActivityList, testNotificationActivity); - addActivity(model, &TestingALM::addErrorToActivityList, testSyncResultErrorActivity); + addActivity(model, &TestingALM::addErrorToActivityList, testSyncResultErrorActivity, OCC::ActivityListModel::ErrorType::SyncError); addActivity(model, &TestingALM::addIgnoredFileToList, testFileIgnoredActivity); } @@ -147,7 +162,7 @@ private slots: addActivity(model, &TestingALM::addSyncFileItemToActivityList, errorSyncFileItemActivity); addActivity(model, &TestingALM::addSyncFileItemToActivityList, testSyncFileItemActivity); addActivity(model, &TestingALM::addNotificationToActivityList, testNotificationActivity); - addActivity(model, &TestingALM::addErrorToActivityList, testSyncResultErrorActivity); + addActivity(model, &TestingALM::addErrorToActivityList, testSyncResultErrorActivity, OCC::ActivityListModel::ErrorType::SyncError); addActivity(model, &TestingALM::addIgnoredFileToList, testFileIgnoredActivity); const QVector activityDefaultTypeOrder { -- 2.30.2