From dc9eaef1e5143a0276d3fa144b7f295f4f01274a Mon Sep 17 00:00:00 2001 From: Luke Yang Date: Wed, 12 Jun 2024 15:50:54 -0400 Subject: [PATCH] tree: Fix `name` memory leak Coverity points out that we have a memory leak from `g_strdup(name)`. `insert_child_mtree()` takes a const char * and duplicates it. `name` can be passed directly to `insert_child_mtree()`. --- src/libostree/ostree-mutable-tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libostree/ostree-mutable-tree.c b/src/libostree/ostree-mutable-tree.c index 3a47de61..29f72a90 100644 --- a/src/libostree/ostree-mutable-tree.c +++ b/src/libostree/ostree-mutable-tree.c @@ -452,7 +452,7 @@ ostree_mutable_tree_ensure_parent_dirs (OstreeMutableTree *self, GPtrArray *spli invalidate_contents_checksum (subdir); next = ostree_mutable_tree_new (); ostree_mutable_tree_set_metadata_checksum (next, metadata_checksum); - insert_child_mtree (subdir, g_strdup (name), next); + insert_child_mtree (subdir, name, next); } subdir = next; -- 2.30.2