From db8c8d68135f1f94398bf418b745796bae99b45a Mon Sep 17 00:00:00 2001 From: Ben Hutchings Date: Sun, 14 Jan 2018 19:27:18 +0000 Subject: [PATCH] Revert "objtool: Fix CONFIG_STACK_VALIDATION=y warning for out-of-tree modules" This reverts commit 9f0c18aec620bc9d82268b3cb937568dd07b43ff. This check doesn't make sense for OOT modules as they should always use a pre-built objtool. Gbp-Pq: Topic debian Gbp-Pq: Name revert-objtool-fix-config_stack_validation-y-warning.patch --- Makefile | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/Makefile b/Makefile index 5d0a7f60ed6..649a00946ca 100644 --- a/Makefile +++ b/Makefile @@ -1019,17 +1019,6 @@ export mod_sign_cmd HOST_LIBELF_LIBS = $(shell pkg-config libelf --libs 2>/dev/null || echo -lelf) -ifdef CONFIG_STACK_VALIDATION - has_libelf := $(call try-run,\ - echo "int main() {}" | $(HOSTCC) -xc -o /dev/null $(HOST_LIBELF_LIBS) -,1,0) - ifeq ($(has_libelf),1) - objtool_target := tools/objtool FORCE - else - SKIP_STACK_VALIDATION := 1 - export SKIP_STACK_VALIDATION - endif -endif - PHONY += prepare0 export MODORDER := $(extmod-prefix)modules.order @@ -1157,6 +1146,17 @@ uapi-asm-generic: $(Q)$(MAKE) $(asm-generic)=arch/$(SRCARCH)/include/generated/uapi/asm \ generic=include/uapi/asm-generic +ifdef CONFIG_STACK_VALIDATION + has_libelf := $(call try-run,\ + echo "int main() {}" | $(HOSTCC) -xc -o /dev/null $(HOST_LIBELF_LIBS) -,1,0) + ifeq ($(has_libelf),1) + objtool_target := tools/objtool FORCE + else + SKIP_STACK_VALIDATION := 1 + export SKIP_STACK_VALIDATION + endif +endif + PHONY += prepare-objtool prepare-objtool: $(objtool_target) ifeq ($(SKIP_STACK_VALIDATION),1) -- 2.30.2