From d89d78912179fb6591f43abff879f43e37ba4654 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Thu, 18 Jun 2015 14:55:18 +0200 Subject: [PATCH] slightly simplify SCHEDOP_remote_shutdown handling There's no need for two exit paths each using rcu_unlock_domain() on its own here. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Acked-by: George Dunlap --- xen/common/schedule.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/xen/common/schedule.c b/xen/common/schedule.c index 3325ccdd27..ecf154557c 100644 --- a/xen/common/schedule.c +++ b/xen/common/schedule.c @@ -970,16 +970,10 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) break; ret = xsm_schedop_shutdown(XSM_DM_PRIV, current->domain, d); - if ( ret ) - { - rcu_unlock_domain(d); - return ret; - } - - domain_shutdown(d, (u8)sched_remote_shutdown.reason); + if ( likely(!ret) ) + domain_shutdown(d, sched_remote_shutdown.reason); rcu_unlock_domain(d); - ret = 0; break; } -- 2.30.2