From cbad95a756467f8ccc07d6d00bfff8d689e0c1c9 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C3=98yvind=20Kol=C3=A5s?= Date: Wed, 9 Feb 2022 20:03:46 +0100 Subject: [PATCH] babl: fix mutex lock/unlocks symmetry in babl_fish() In the case where the fish we are to look up is the memcpy fish we were not locking the mutex. Whereas the common cleanup after the branches assumes the lock is held. This is probably the cause of gimp#7632. --- babl/babl-fish.c | 1 + 1 file changed, 1 insertion(+) diff --git a/babl/babl-fish.c b/babl/babl-fish.c index aece33b..06d7961 100644 --- a/babl/babl-fish.c +++ b/babl/babl-fish.c @@ -253,6 +253,7 @@ babl_fish (const void *source, * we will search through the fish database for reference fish * to handle the memcpy */ babl_hash_table_find (id_htable, hashval, find_memcpy_fish, (void *) &ffish); + babl_mutex_lock (babl_fish_mutex); } else { -- 2.30.2