From c4b1adf1356af68a0b47031d5e52b052c4117cc6 Mon Sep 17 00:00:00 2001 From: LLVM Packaging Team Date: Mon, 11 Sep 2023 14:40:42 +0100 Subject: [PATCH] wasm-sysroot-usr Gbp-Pq: Topic wasm Gbp-Pq: Name wasm-sysroot-usr.diff --- clang/lib/Driver/ToolChains/WebAssembly.cpp | 43 ++++++++++++++++----- clang/lib/Driver/ToolChains/WebAssembly.h | 2 + 2 files changed, 36 insertions(+), 9 deletions(-) diff --git a/clang/lib/Driver/ToolChains/WebAssembly.cpp b/clang/lib/Driver/ToolChains/WebAssembly.cpp index 6b0e5cc646..0e4754fbd8 100644 --- a/clang/lib/Driver/ToolChains/WebAssembly.cpp +++ b/clang/lib/Driver/ToolChains/WebAssembly.cpp @@ -174,7 +174,7 @@ WebAssembly::WebAssembly(const Driver &D, const llvm::Triple &Triple, getProgramPaths().push_back(getDriver().getInstalledDir()); - auto SysRoot = getDriver().SysRoot; + std::string SysRoot = computeSysRoot(); if (getTriple().getOS() == llvm::Triple::UnknownOS) { // Theoretically an "unknown" OS should mean no standard libraries, however // it could also mean that a custom set of libraries is in use, so just add @@ -402,6 +402,7 @@ void WebAssembly::AddClangSystemIncludeArgs(const ArgList &DriverArgs, return; const Driver &D = getDriver(); + std::string SysRoot = computeSysRoot(); if (!DriverArgs.hasArg(options::OPT_nobuiltininc)) { SmallString<128> P(D.ResourceDir); @@ -425,12 +426,20 @@ void WebAssembly::AddClangSystemIncludeArgs(const ArgList &DriverArgs, return; } + // add the multiarch path on e.g. wasm32-wasi if (getTriple().getOS() != llvm::Triple::UnknownOS) { const std::string MultiarchTriple = - getMultiarchTriple(D, getTriple(), D.SysRoot); - addSystemInclude(DriverArgs, CC1Args, D.SysRoot + "/include/" + MultiarchTriple); + getMultiarchTriple(D, getTriple(), SysRoot); + addSystemInclude(DriverArgs, CC1Args, SysRoot + "/local/include/" + MultiarchTriple); + addSystemInclude(DriverArgs, CC1Args, SysRoot + "/local/include"); + addSystemInclude(DriverArgs, CC1Args, SysRoot + "/include/" + MultiarchTriple); } - addSystemInclude(DriverArgs, CC1Args, D.SysRoot + "/include"); + + // also add the non-multiarch path, only on a known OS (as above), or when + // a sysroot is given, for backwards compatibility with the original driver + if (getTriple().getOS() != llvm::Triple::UnknownOS || + !getDriver().SysRoot.empty()) + addSystemInclude(DriverArgs, CC1Args, SysRoot + "/include"); } void WebAssembly::AddClangCXXStdlibIncludeArgs(const ArgList &DriverArgs, @@ -478,6 +487,17 @@ Tool *WebAssembly::buildLinker() const { return new tools::wasm::Linker(*this); } +std::string WebAssembly::computeSysRoot() const { + if (!getDriver().SysRoot.empty()) + return getDriver().SysRoot; + + std::string Path = "/usr"; + if (getVFS().exists(Path)) + return Path; + + return std::string(); +} + void WebAssembly::addLibCxxIncludePaths( const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args) const { @@ -499,7 +519,9 @@ void WebAssembly::addLibCxxIncludePaths( } // Second add the generic one. - addSystemInclude(DriverArgs, CC1Args, LibPath + "/c++/" + Version); + // don't include the host architecture's headers in the search path + if (!getDriver().SysRoot.empty()) + addSystemInclude(DriverArgs, CC1Args, LibPath + "/c++/" + Version); } void WebAssembly::addLibStdCXXIncludePaths( @@ -546,8 +568,11 @@ void WebAssembly::addLibStdCXXIncludePaths( addSystemInclude(DriverArgs, CC1Args, TargetDir); } - // Second add the generic one. - addSystemInclude(DriverArgs, CC1Args, LibPath + "/c++/" + Version); - // Third the backward one. - addSystemInclude(DriverArgs, CC1Args, LibPath + "/c++/" + Version + "/backward"); + // don't include the host architecture's headers in the search path + if (!getDriver().SysRoot.empty()) { + // Second add the generic one. + addSystemInclude(DriverArgs, CC1Args, LibPath + "/c++/" + Version); + // Third the backward one. + addSystemInclude(DriverArgs, CC1Args, LibPath + "/c++/" + Version + "/backward"); + } } diff --git a/clang/lib/Driver/ToolChains/WebAssembly.h b/clang/lib/Driver/ToolChains/WebAssembly.h index 4461f06f8a..1de4d0ea66 100644 --- a/clang/lib/Driver/ToolChains/WebAssembly.h +++ b/clang/lib/Driver/ToolChains/WebAssembly.h @@ -89,6 +89,8 @@ private: llvm::opt::ArgStringList &CC1Args) const; void addLibStdCXXIncludePaths(const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args) const; + + std::string computeSysRoot() const override; }; } // end namespace toolchains -- 2.30.2