From c2d72109b626c656b095134da532e9250ca2dda7 Mon Sep 17 00:00:00 2001 From: Matthieu Gallien Date: Thu, 13 Apr 2023 18:41:44 +0200 Subject: [PATCH] protext all access to _logstream with the existing mutex Signed-off-by: Matthieu Gallien --- src/libsync/logger.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libsync/logger.cpp b/src/libsync/logger.cpp index 42830d32f..d38be4c6b 100644 --- a/src/libsync/logger.cpp +++ b/src/libsync/logger.cpp @@ -118,7 +118,6 @@ void Logger::doLog(QtMsgType type, const QMessageLogContext &ctx, const QString cout << msg << endl; #endif { - QMutexLocker lock(&_mutex); if (_logFile.size() >= MaxLogSizeBytes) { close(); enterNextLogFile(); @@ -127,6 +126,8 @@ void Logger::doLog(QtMsgType type, const QMessageLogContext &ctx, const QString _crashLogIndex = (_crashLogIndex + 1) % CrashLogSize; _crashLog[_crashLogIndex] = msg; + QMutexLocker lock(&_mutex); + if (_logstream) { (*_logstream) << msg << Qt::endl; if (_doFileFlush) @@ -145,6 +146,7 @@ void Logger::doLog(QtMsgType type, const QMessageLogContext &ctx, const QString void Logger::close() { + QMutexLocker lock(&_mutex); dumpCrashLog(); if (_logstream) { -- 2.30.2