From be464973e4565fd9b4999a6eb9db9f469616f07b Mon Sep 17 00:00:00 2001 From: Luca Fancellu Date: Wed, 8 Jun 2022 16:59:55 +0200 Subject: [PATCH] tools/libxl: optimize domain creation skipping domain cpupool move Commit 92ea9c54fc81 ("arm/dom0less: assign dom0less guests to cpupools") introduced a way to start a domain directly on a certain cpupool, adding a "cpupool_id" member to struct xen_domctl_createdomain. This was done to be able to start dom0less guests in different pools than cpupool0, but the toolstack can benefit from it because it can now use the struct member directly instead of creating the guest in cpupool0 and then moving it to the target cpupool. Suggested-by: Andrew Cooper Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross Acked-by: Anthony PERARD --- tools/libs/light/libxl_create.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 69ec405858..2339f09e95 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -633,6 +633,7 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config, .max_maptrack_frames = b_info->max_maptrack_frames, .grant_opts = XEN_DOMCTL_GRANT_version(b_info->max_grant_version), .vmtrace_size = ROUNDUP(b_info->vmtrace_buf_kb << 10, XC_PAGE_SHIFT), + .cpupool_id = info->poolid, }; if (info->type != LIBXL_DOMAIN_TYPE_PV) { @@ -757,13 +758,6 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config, */ assert(libxl_domid_valid_guest(*domid)); - ret = xc_cpupool_movedomain(ctx->xch, info->poolid, *domid); - if (ret < 0) { - LOGED(ERROR, *domid, "domain move fail"); - rc = ERROR_FAIL; - goto out; - } - dom_path = libxl__xs_get_dompath(gc, *domid); if (!dom_path) { rc = ERROR_FAIL; -- 2.30.2