From b9d4e7045ea06ebf496d712036a7a07acdee04ba Mon Sep 17 00:00:00 2001 From: Matthieu Gallien Date: Wed, 12 Oct 2022 12:05:45 +0200 Subject: [PATCH] fix review comments from @allexzander Signed-off-by: Matthieu Gallien --- src/libsync/clientsideencryption.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/libsync/clientsideencryption.cpp b/src/libsync/clientsideencryption.cpp index 8607f9866..2408b6ade 100644 --- a/src/libsync/clientsideencryption.cpp +++ b/src/libsync/clientsideencryption.cpp @@ -1202,10 +1202,11 @@ void ClientSideEncryption::sendSignRequestCSR(const AccountPtr &account, PKey ke const auto certificatePem = _certificate.toPem(); BIO_write(certificateBio, certificatePem.constData(), certificatePem.size()); const auto x509Certificate = X509Certificate::readCertificate(certificateBio); - if (const auto certificateCheckResult = X509_check_private_key(x509Certificate, keyPair) ; !certificateCheckResult) { - auto lastError = 1UL; - while ((lastError= ERR_get_error())) { + if (!X509_check_private_key(x509Certificate, keyPair)) { + auto lastError = ERR_get_error(); + while (lastError) { qCInfo(lcCse()) << ERR_lib_error_string(lastError); + lastError = ERR_get_error(); } forgetSensitiveData(account); return; -- 2.30.2