From b91839b760c8fc0ec1f7cedf2d820e3b0f1e9c40 Mon Sep 17 00:00:00 2001
From: Christian Kamm <mail@ckamm.de>
Date: Mon, 14 Jan 2019 15:44:50 +0100
Subject: [PATCH] SyncEngine: Rename phase finishing slots

slotDiscoveryJobFinished -> slotDiscoveryFinished
slotFinished -> slotPropagationFinished

This should be clearer. Particular the
slotFinished -> finalize -> emit finished()
chain was confusing before.
---
 src/libsync/progressdispatcher.h | 2 +-
 src/libsync/syncengine.cpp       | 8 ++++----
 src/libsync/syncengine.h         | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/libsync/progressdispatcher.h b/src/libsync/progressdispatcher.h
index fdb13bbda..17e1601a9 100644
--- a/src/libsync/progressdispatcher.h
+++ b/src/libsync/progressdispatcher.h
@@ -63,7 +63,7 @@ public:
          * Emitted once when done
          *
          * Except when SyncEngine jumps directly to finalize() without going
-         * through slotFinished().
+         * through slotPropagationFinished().
          */
         Done
     };
diff --git a/src/libsync/syncengine.cpp b/src/libsync/syncengine.cpp
index afa8cdfdb..c1613eb57 100644
--- a/src/libsync/syncengine.cpp
+++ b/src/libsync/syncengine.cpp
@@ -617,7 +617,7 @@ void SyncEngine::slotStartDiscovery()
         syncError(errorString);
         finalize(false);
     });
-    connect(_discoveryPhase.data(), &DiscoveryPhase::finished, this, &SyncEngine::slotDiscoveryJobFinished);
+    connect(_discoveryPhase.data(), &DiscoveryPhase::finished, this, &SyncEngine::slotDiscoveryFinished);
 
     auto discoveryJob = new ProcessDirectoryJob(SyncFileItemPtr(), ProcessDirectoryJob::NormalQuery, ProcessDirectoryJob::NormalQuery,
         _discoveryPhase.data(), _discoveryPhase.data());
@@ -660,7 +660,7 @@ void SyncEngine::slotNewItem(const SyncFileItemPtr &item)
     _progressInfo->adjustTotalsForFile(*item);
 }
 
-void SyncEngine::slotDiscoveryJobFinished()
+void SyncEngine::slotDiscoveryFinished()
 {
     if (!_discoveryPhase) {
         // There was an error that was already taken care of
@@ -749,7 +749,7 @@ void SyncEngine::slotDiscoveryJobFinished()
         this, &SyncEngine::slotItemCompleted);
     connect(_propagator.data(), &OwncloudPropagator::progress,
         this, &SyncEngine::slotProgress);
-    connect(_propagator.data(), &OwncloudPropagator::finished, this, &SyncEngine::slotFinished, Qt::QueuedConnection);
+    connect(_propagator.data(), &OwncloudPropagator::finished, this, &SyncEngine::slotPropagationFinished, Qt::QueuedConnection);
     connect(_propagator.data(), &OwncloudPropagator::seenLockedFile, this, &SyncEngine::seenLockedFile);
     connect(_propagator.data(), &OwncloudPropagator::touchedFile, this, &SyncEngine::slotAddTouchedFile);
     connect(_propagator.data(), &OwncloudPropagator::insufficientLocalStorage, this, &SyncEngine::slotInsufficientLocalStorage);
@@ -811,7 +811,7 @@ void SyncEngine::slotItemCompleted(const SyncFileItemPtr &item)
     emit itemCompleted(item);
 }
 
-void SyncEngine::slotFinished(bool success)
+void SyncEngine::slotPropagationFinished(bool success)
 {
     if (_propagator->_anotherSyncNeeded && _anotherSyncNeeded == NoFollowUpSync) {
         _anotherSyncNeeded = ImmediateFollowUp;
diff --git a/src/libsync/syncengine.h b/src/libsync/syncengine.h
index 49927772f..49523eb47 100644
--- a/src/libsync/syncengine.h
+++ b/src/libsync/syncengine.h
@@ -181,9 +181,9 @@ private slots:
     void slotNewItem(const SyncFileItemPtr &item);
 
     void slotItemCompleted(const SyncFileItemPtr &item);
-    void slotFinished(bool success);
+    void slotDiscoveryFinished();
+    void slotPropagationFinished(bool success);
     void slotProgress(const SyncFileItem &item, quint64 curent);
-    void slotDiscoveryJobFinished();
     void slotCleanPollsJobAborted(const QString &error);
 
     /** Records that a file was touched by a job. */
-- 
2.30.2