From b4b282dc81641de12fdd276e6dc9bb4dedb5b114 Mon Sep 17 00:00:00 2001 From: Christian Hergert Date: Thu, 17 Feb 2022 12:39:21 -0800 Subject: [PATCH] macos: fix allocation for filechoosernative filter The GtkFileCHooserNativeQuartz injects a NSComboBox into the NSSavePanel (which is displayed in a remote process since 10.15 whether or not you are a sandboxed application). The style has changed and we need more space here to not clip part of the combobox out of view. I tried every size from 22 to 30 and this seemed to look the most natural without skewing the location of the text within the combobox. --- gtk/gtkfilechoosernativequartz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/gtkfilechoosernativequartz.c b/gtk/gtkfilechoosernativequartz.c index c004167a23..3854937c0d 100644 --- a/gtk/gtkfilechoosernativequartz.c +++ b/gtk/gtkfilechoosernativequartz.c @@ -300,7 +300,7 @@ filechooser_quartz_launch (FileChooserQuartzData *data) if (data->filters) { // when filters have been provided, a combobox needs to be added - data->filter_combo_box = [[NSComboBox alloc] initWithFrame:NSMakeRect(0.0, 0.0, 200, 20)]; + data->filter_combo_box = [[NSComboBox alloc] initWithFrame:NSMakeRect(0, 0, 200, 24)]; [data->filter_combo_box addItemsWithObjectValues:data->filter_names]; [data->filter_combo_box setEditable:NO]; [data->filter_combo_box setDelegate:[[FilterComboBox alloc] initWithData:data]]; -- 2.30.2