From b22db3fcba1a5b4f9e563b58d402f1d5c434209f Mon Sep 17 00:00:00 2001 From: Julien Grall Date: Wed, 25 May 2022 09:52:38 +0100 Subject: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice() xsm_deassign_dtdevice() will indicate whether the caller is allowed to issue the operation. So the return value has to be checked. Spotted by clang static analyzer. Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device") Signed-off-by: Julien Grall Reviewed-by: Michal Orzel Reviewed-by: Bertrand Marquis --- xen/drivers/passthrough/device_tree.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 98f2aa0dad..1c32d7b50c 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -269,6 +269,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, break; ret = xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); + if ( ret ) + break; if ( d == dom_io ) return -EINVAL; -- 2.30.2