From af3d18b4fc492a83fdc47a4f980d9ab7c1990c0c Mon Sep 17 00:00:00 2001 From: Jonathan Dieter Date: Fri, 14 Sep 2018 13:11:46 +0100 Subject: [PATCH] Set umask before running mkstemp because some UNIX flavors don't do this automatically. (Coverity ID: 310912) Signed-off-by: Jonathan Dieter --- src/lib/zck.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/lib/zck.c b/src/lib/zck.c index a3359ea..eb58f8a 100644 --- a/src/lib/zck.c +++ b/src/lib/zck.c @@ -29,6 +29,7 @@ #include #include #include +#include #include #include #include @@ -130,7 +131,10 @@ int get_tmp_fd(zckCtx *zck) { strncpy(fname+strlen(tmpdir), "/", 2); strncpy(fname+strlen(tmpdir)+1, template, strlen(template)); + mode_t old_mode_mask; + old_mode_mask = umask (S_IXUSR | S_IRWXG | S_IRWXO); temp_fd = mkstemp(fname); + umask(old_mode_mask); if(temp_fd < 0) { free(fname); set_error(zck, "Unable to create temporary file"); -- 2.30.2