From ae7c6b64c063a755097806e30dc24b94fabbda09 Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Wed, 25 Sep 2013 10:45:53 +0200 Subject: [PATCH] x86/hap: Remove bogus assertion in hap_free_p2m_page() Coverity ID: 1055622 Coverity correctly points out that this ASSERT() is unconditionally true as an unsigned integer is always >= 0. Judging from the shadow counterpart and p2m callsites, there is nothing invalid about freeing the final p2m page. Signed-off-by: Andrew Cooper Acked-by: Tim Deegan --- xen/arch/x86/mm/hap/hap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c index bff05d97a3..d3f64bdb97 100644 --- a/xen/arch/x86/mm/hap/hap.c +++ b/xen/arch/x86/mm/hap/hap.c @@ -289,7 +289,6 @@ static void hap_free_p2m_page(struct domain *d, struct page_info *pg) d->arch.paging.hap.p2m_pages--; d->arch.paging.hap.total_pages++; hap_free(d, page_to_mfn(pg)); - ASSERT(d->arch.paging.hap.p2m_pages >= 0); paging_unlock(d); } -- 2.30.2