From ae00156784e6c9ce1024f287078938d8961d3c69 Mon Sep 17 00:00:00 2001 From: Hans van Kranenburg Date: Fri, 5 Aug 2022 11:48:41 +0200 Subject: [PATCH] debian/*lintian-overrides*: move comments above overrides The Lintian documentation tells us to put documentation for overrides above the override line itself. https://lintian.debian.org/manual/index.html#documenting-overrides --- debian/libxenmiscV.lintian-overrides.vsn-in | 8 ++++---- debian/xen-doc.lintian-overrides | 4 ++-- debian/xen-hypervisor-V-F.lintian-overrides.vsn-in | 6 +++--- debian/xen-utils-V.lintian-overrides.vsn-in | 10 +++++----- debian/xenstore-utils.lintian-overrides | 6 +++--- 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/debian/libxenmiscV.lintian-overrides.vsn-in b/debian/libxenmiscV.lintian-overrides.vsn-in index 562575ac90..e2ab9a8af7 100644 --- a/debian/libxenmiscV.lintian-overrides.vsn-in +++ b/debian/libxenmiscV.lintian-overrides.vsn-in @@ -1,7 +1,7 @@ +# The ABI changes every Xen release and every Debian release anyway +# and we do not upload to Debian packages based on Xen upstream +# versions which are at least an rc with a stable ABI. no-symbols-control-file usr/lib/*/lib*.so.@version@.0 -# ^ the ABI changes every Xen release and every Debian release anyway -# and we do not upload to Debian packages based on Xen upstream -# versions which are at least an rc with a stable ABI. +# Yes, this is a portmanteau package. They all change at once. package-name-doesnt-match-sonames -# ^ yes, this is a portmanteau package. They all change at once. diff --git a/debian/xen-doc.lintian-overrides b/debian/xen-doc.lintian-overrides index 13a78a2385..c2286c5720 100644 --- a/debian/xen-doc.lintian-overrides +++ b/debian/xen-doc.lintian-overrides @@ -1,3 +1,3 @@ +# Indeed not. It is arch-specific because the Xen upstream HTML +# documentation contains arch-specific hypercall API information. documentation-package-not-architecture-independent -# ^ Indeed not. It is arch-specific because the Xen upstream HTML -# documentation contains arch-specific hhypercall API information. diff --git a/debian/xen-hypervisor-V-F.lintian-overrides.vsn-in b/debian/xen-hypervisor-V-F.lintian-overrides.vsn-in index b0362510ca..5c6df104ac 100644 --- a/debian/xen-hypervisor-V-F.lintian-overrides.vsn-in +++ b/debian/xen-hypervisor-V-F.lintian-overrides.vsn-in @@ -1,4 +1,4 @@ +# Aas is traditional for kernels too, we ship the debug information +# in the hypervisor package rather than creating yet another +# package just for this file, which is only 50K or so anyway. debug-suffix-not-dbg usr/lib/debug/xen-*.efi.map.gz -# ^ as is traditional for kernels too, we ship the debug information -# in the hypervisor package rather than creating yet another -# package just for this file, which is only 50K or so anyway. diff --git a/debian/xen-utils-V.lintian-overrides.vsn-in b/debian/xen-utils-V.lintian-overrides.vsn-in index 8c0e496b11..f6aadc40ae 100644 --- a/debian/xen-utils-V.lintian-overrides.vsn-in +++ b/debian/xen-utils-V.lintian-overrides.vsn-in @@ -1,13 +1,13 @@ statically-linked-binary usr/lib/xen-@version@/boot/hvmloader statically-linked-binary usr/lib/xen-@version@/boot/xen-shim +# That section is certainly needed for the tools etc. to be able +# to load it! binary-has-unneeded-section usr/lib/xen-@version@/boot/xen-shim .note -# ^ that section is certainly needed for the tools etc. to be able -# to load it! +# This is a symbols file for the shim binary-from-other-architecture usr/lib/debug/xen-syms-@version@-shim/xen-shim-syms -# ^ this is a symbols file for the shim +# This module needs to load the libxenfsimage .so from within +# the xen-utils private directory. less +/xenfsimage debian/rules binary-or-shlib-defines-rpath usr/lib/xen-@version@/lib/python/xenfsimage.*.so /usr/lib/xen-@version@/lib/x86_64-linux-gnu -# ^ this module needs to load the libxenfsimage .so from within -# the xen-utils private directory. less +/xenfsimage debian/rules diff --git a/debian/xenstore-utils.lintian-overrides b/debian/xenstore-utils.lintian-overrides index 7ba6bc17a7..d1ce021e23 100644 --- a/debian/xenstore-utils.lintian-overrides +++ b/debian/xenstore-utils.lintian-overrides @@ -1,6 +1,6 @@ +# These have --upto as a command line argument spelling-error-in-binary usr/bin/xenstore* upto up to -# ^ these have --upto as a command line argument +# It's not a homepage, it's a reference to help understand +# why this package might be useful. description-possibly-contains-homepage https://wiki.xen.org/wiki/XenStore -# ^ It's not a homepage, it's a reference to help understand -# why this package might be useful. -- 2.30.2