From ab8fc3937eeb9332b83d7e14d81e37f0b0ef1841 Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Wed, 3 Aug 2016 10:48:42 +0100 Subject: [PATCH] x86/mmcfg: Fix initalisation of variables in pci_mmcfg_nvidia_mcp55() Shifting into the sign bit of an integer is undefined behaviour. Only the first integer is actually undefined, but switch all the shifts for consistency. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- xen/arch/x86/x86_64/mmconfig-shared.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/x86_64/mmconfig-shared.c b/xen/arch/x86/x86_64/mmconfig-shared.c index 742bc1862f..a7592c6fe9 100644 --- a/xen/arch/x86/x86_64/mmconfig-shared.c +++ b/xen/arch/x86/x86_64/mmconfig-shared.c @@ -182,10 +182,10 @@ static const char __init *pci_mmcfg_nvidia_mcp55(void) int bus, i; static const u32 extcfg_regnum = 0x90; - static const u32 extcfg_enable_mask = 1<<31; - static const u32 extcfg_start_mask = 0xff<<16; + static const u32 extcfg_enable_mask = 1u << 31; + static const u32 extcfg_start_mask = 0xffu << 16; static const int extcfg_start_shift = 16; - static const u32 extcfg_size_mask = 0x3<<28; + static const u32 extcfg_size_mask = 3u << 28; static const int extcfg_size_shift = 28; static const int extcfg_sizebus[] = {0xff, 0x7f, 0x3f, 0x1f}; static const u32 extcfg_base_mask[] = {0x7ff8, 0x7ffc, 0x7ffe, 0x7fff}; -- 2.30.2