From a87789e818dddfad26d9870592ff441b765f2afc Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Fri, 25 Aug 2023 16:53:11 -0400 Subject: [PATCH] commit: Drop dead code Coverity points out that since we're now *always* initializing metadata, the `create_empty_gvariant_dict()` is unreachable. --- src/libostree/ostree-repo-commit.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c index 1bc3394b..92d09ad2 100644 --- a/src/libostree/ostree-repo-commit.c +++ b/src/libostree/ostree-repo-commit.c @@ -2850,14 +2850,6 @@ ostree_repo_write_content_finish (OstreeRepo *self, GAsyncResult *result, guchar return TRUE; } -static GVariant * -create_empty_gvariant_dict (void) -{ - GVariantBuilder builder; - g_variant_builder_init (&builder, G_VARIANT_TYPE ("a{sv}")); - return g_variant_builder_end (&builder); -} - /** * ostree_repo_write_commit: * @self: Repo @@ -2951,7 +2943,7 @@ ostree_repo_write_commit_with_time (OstreeRepo *self, const char *parent, const return FALSE; g_autoptr (GVariant) commit = g_variant_new ( - "(@a{sv}@ay@a(say)sst@ay@ay)", new_metadata ? new_metadata : create_empty_gvariant_dict (), + "(@a{sv}@ay@a(say)sst@ay@ay)", new_metadata, parent ? ostree_checksum_to_bytes_v (parent) : ot_gvariant_new_bytearray (NULL, 0), g_variant_new_array (G_VARIANT_TYPE ("(say)"), NULL, 0), subject ? subject : "", body ? body : "", GUINT64_TO_BE (time), -- 2.30.2