From a8002238b49c3423c7081dfbac3580651f5242ef Mon Sep 17 00:00:00 2001 From: Julien Grall Date: Thu, 24 Jun 2021 09:07:52 +0100 Subject: [PATCH] tools/xenstored: xenstored_core.h should include fcntl.h xenstored_core.h will consider live-udpate is not supported if O_CLOEXEC doesn't exist. However, the header doesn't include the one defining O_CLOEXEC (i.e. fcntl.h). This means that depending on the header included, some source file will think Live-Update is not supported. I am not aware of any issue with the existing. Therefore this is just a latent bug so far. Prevent any potential issue by including fcntl.h in xenstored_core.h Fixes: cd831ee438 ("tools/xenstore: handle CLOEXEC flag for local files and pipes") Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu Reviewed-by: Juergen Gross --- tools/xenstore/xenstored_core.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 34839b34f6..dac5171569 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -24,6 +24,7 @@ #include #include +#include #include #include #include -- 2.30.2