From a78647d89acce6e6b0f61fde8efdfa15782bc92a Mon Sep 17 00:00:00 2001 From: Jonathan Dieter Date: Fri, 14 Sep 2018 15:26:54 +0100 Subject: [PATCH] Make sure TMPDIR has a size limit (Coverity ID: 310902) Signed-off-by: Jonathan Dieter --- src/lib/zck.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/lib/zck.c b/src/lib/zck.c index fd04067..3b2fa07 100644 --- a/src/lib/zck.c +++ b/src/lib/zck.c @@ -129,7 +129,11 @@ int get_tmp_fd(zckCtx *zck) { if(tmpdir == NULL) { tmpdir = "/tmp/"; + } else if(strlen(tmpdir) > 1024) { + set_error(zck, "TMPDIR environmental variable is > 1024 bytes"); + return -1; } + fname = zmalloc(strlen(template) + strlen(tmpdir) + 2); strncpy(fname, tmpdir, strlen(tmpdir)); strncpy(fname+strlen(tmpdir), "/", 2); -- 2.30.2