From a68fea41a236043f086318e6dccdd4e873c574e0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Caol=C3=A1n=20McNamara?= Date: Sun, 26 Apr 2026 15:49:32 +0000 Subject: [PATCH] [PATCH] SdrEscherImport::RecolorGraphic reads but doesn't use FillColors MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit it never did, but at: commit 025bfa7e510bdab3ef93ad45a731fc25085ba3cc Date: Thu Apr 23 10:03:58 2015 +0100 cppcheck: unreadVariable the wrong choice was made wrt the dead store, the dead loop should have been fixed rather than let the unused fill colors accumulate in the globalcolors buffer. This function doesn't need to consume the unused data, all callers don't expect the entire record to be read so just drop the loop. Signed-off-by: Caolán McNamara Change-Id: I02bce4dd78dc566f18edc3d45603534c3f724cc3 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1689 (cherry picked from commit 07faeadace3d8d93225f9dd72c4f911e331070e2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205089 Tested-by: Jenkins Reviewed-by: Xisco Fauli (cherry picked from commit 9ba100c0d2131862c9356a86906921abc80d8f98) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205097 Gbp-Pq: Name CVE-2026-8356.diff --- filter/source/msfilter/svdfppt.cxx | Bin 329666 -> 329236 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx index 74f8da16fac6169bf8f2f636e09ab2f1c2a5000e..66f6e99680e25eaf0d1cbd91fe915945e3daed1d 100644 GIT binary patch delta 482 zcmX@qFEXV^WW#&+Nx`C%eLcAJ((;QGG!%*xbK*-q^Gb}36fzZT6%4F_l#N23drp2* zVvciuPJU6bbAD-F$>acOvFY&>nK&k=d&*7j^b}^*FwnH-n!I73$mDIF64PgUGILJ8 z?I}F{%^W7N$vj><)AxHb@vwtU&@h-DSjZwhIp2#Fs;kP&cv=7p+hl)V87R#@SWNQ?lV6wc21e3P*bi=t!B9oW+Nl(}O%goKFI4M|cdh-QFvB|Oi%S4ePCkqle dSqe5lhl@5V1+*&#Faj|X5HoLA3Se2V9RQ1snJoYS delta 819 zcmbQzBXX!;WW#%R)=V9RES<>fU;us zwpe5pY!wWwxj;%3iW76SjE%Gu3Y<%eic<4R{EITvGxHL2fXZM@_niEsM5q;D zv$1OQODzZL0g?#iaz(}1)aRGxl>n8hO-}F=wFEmP6Ufa&=mYu$qz3BBwEQ9k4TUVA z5(8@>WussOq_nlCe^6o)<5jR$$W*Wc$z0Io&~knPYO4huq}VuQ{h5xWdHF z4h@#c2ff87FZ7U}es2mR=j4MP;*;k*7Mt#{mXTxfI}e@71`}DPKPYA5nO?`o#4&x# z0~Ybg4xYTz8v~hyC$HPVKKZ)0{N#XWmdOb|ypx%IM4@aIxR|GpIEI*lml#xxZL*y< z`($S?@yP|tSf*cy0J<>=DA~{}HMz^n0j%hhmj;;rO%Rwz7#c^ztr~B}M%!b(^47URo_Xvx)HGqdq)Id5iBfE<}<5WrgMvzxEP8Mj&PaV&?57ek=>N0{~La4p0C9 -- 2.30.2