From a57b1fff48a8e7f3791156f9cfafc174b9f18e2b Mon Sep 17 00:00:00 2001 From: Chen Baozi Date: Tue, 7 Apr 2015 15:33:52 +0800 Subject: [PATCH] xen/arm64: Avoid sending SGI when kicking secondary cpus with spin_table On arm64, either firmware or xen's smp_up_cpu gate uses WFE on secondary cpus to stand-by when booting. Thus, using SEV is enough for the boot cpu to kick other secondaries. Further more, the current implementation of cpu_up_send_sgi would pass a NULL cpumask pointer to send_SGI, which then lead a data fault on GICv3 send_SGI implementation. Signed-off-by: Chen Baozi Acked-by: Ian Campbell --- xen/arch/arm/arm64/smpboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c index 341cc77ce4..62e6abb842 100644 --- a/xen/arch/arm/arm64/smpboot.c +++ b/xen/arch/arm/arm64/smpboot.c @@ -38,7 +38,7 @@ static int __init smp_spin_table_cpu_up(int cpu) sev(); - return cpu_up_send_sgi(cpu); + return 0; } static void __init smp_spin_table_init(int cpu, struct dt_device_node *dn) -- 2.30.2