From 9ee1d0395576283b24c87f8d5ec7bb123cadc27c Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Mon, 8 Aug 2016 11:21:31 +0100 Subject: [PATCH] libxl: CODING_STYLE: Forbid if (...) { stmt; } else stmt; And clarify that the rule about omitting braces for single statements is optional (it is even contradicted by the example). Signed-off-by: Ian Jackson Acked-by: Wei Liu --- tools/libxl/CODING_STYLE | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/libxl/CODING_STYLE b/tools/libxl/CODING_STYLE index 01ee25b392..32170efb9e 100644 --- a/tools/libxl/CODING_STYLE +++ b/tools/libxl/CODING_STYLE @@ -294,8 +294,10 @@ Libxenlight coding style is super simple. Avoid tricky expressions. 5. Block structure -Every indented statement is braced, except blocks that contain just -one statement. +Every indented statement is braced, but blocks that contain just one +statement may have the braces omitted. To avoid confusion, either all +the blocks in an if...else chain have braces, or none of them do. + The opening brace is on the line that contains the control flow statement that introduces the new block; the closing brace is on the same line as the else keyword, or on a line by itself if there is no -- 2.30.2