From 9a2982ce85aec92fb828af34041f41b00b723b62 Mon Sep 17 00:00:00 2001 From: Dan Magenheimer Date: Tue, 11 Sep 2012 14:19:03 +0200 Subject: [PATCH] tmem: fixup 2010 cleanup patch that breaks tmem save/restore 20918:a3fa6d444b25 "Fix domain reference leaks" (in Feb 2010, by Jan) does some cleanup in addition to the leak fixes. Unfortunately, that cleanup inadvertently resulted in an incorrect fallthrough in a switch statement which breaks tmem save/restore. That broken patch was apparently applied to 4.0-testing and 4.1-testing so those are broken as well. What is the process now for requesting back-patches to 4.0 and 4.1? (Side note: This does not by itself entirely fix save/restore in 4.2.) Signed-off-by: Dan Magenheimer Signed-off-by: Jan Beulich Committed-by: Jan Beulich --- xen/common/tmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/tmem.c b/xen/common/tmem.c index 091080e3f1..6af8faafec 100644 --- a/xen/common/tmem.c +++ b/xen/common/tmem.c @@ -2419,6 +2419,7 @@ static NOINLINE int tmemc_save_subop(int cli_id, uint32_t pool_id, break; tmh_copy_to_client_buf(buf, pool->uuid, 2); rc = 0; + break; case TMEMC_SAVE_END: if ( client == NULL ) break; @@ -2429,6 +2430,7 @@ static NOINLINE int tmemc_save_subop(int cli_id, uint32_t pool_id, pgp_free_from_inv_list(client,pgp); client->frozen = client->was_frozen; rc = 0; + break; } return rc; } -- 2.30.2