From 97e6c7228a5d86df938d050d8201d57c1341c54f Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Fri, 12 May 2023 14:09:36 -0400 Subject: [PATCH] Revert "css: Simplify default values" This reverts commit 1efa39672b94ba12f42f386d0eedb7ed6d7c3d03. We want to use corner values for corner properties. Fixes: #5892 --- gtk/gtkcssinitialvalue.c | 2 +- gtk/gtkcssstylepropertyimpl.c | 13 ++++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/gtk/gtkcssinitialvalue.c b/gtk/gtkcssinitialvalue.c index 381ec21e61..2ca5efe8b4 100644 --- a/gtk/gtkcssinitialvalue.c +++ b/gtk/gtkcssinitialvalue.c @@ -64,7 +64,7 @@ gtk_css_value_initial_compute (GtkCssValue *value, case GTK_CSS_PROPERTY_FONT_FAMILY: settings = gtk_style_provider_get_settings (provider); if (settings && gtk_settings_get_font_family (settings) != NULL) - return _gtk_css_string_value_new (gtk_settings_get_font_family (settings)); + return _gtk_css_array_value_new (_gtk_css_string_value_new (gtk_settings_get_font_family (settings))); break; default: diff --git a/gtk/gtkcssstylepropertyimpl.c b/gtk/gtkcssstylepropertyimpl.c index c06b31ddfb..f3176a203b 100644 --- a/gtk/gtkcssstylepropertyimpl.c +++ b/gtk/gtkcssstylepropertyimpl.c @@ -1095,25 +1095,29 @@ _gtk_css_style_property_init_properties (void) GTK_STYLE_PROPERTY_ANIMATED, GTK_CSS_AFFECTS_BACKGROUND | GTK_CSS_AFFECTS_BORDER, border_corner_radius_value_parse, - _gtk_css_number_value_new (0, GTK_CSS_PX)); + _gtk_css_corner_value_new (_gtk_css_number_value_new (0, GTK_CSS_PX), + _gtk_css_number_value_new (0, GTK_CSS_PX))); gtk_css_style_property_register ("border-top-right-radius", GTK_CSS_PROPERTY_BORDER_TOP_RIGHT_RADIUS, GTK_STYLE_PROPERTY_ANIMATED, GTK_CSS_AFFECTS_BACKGROUND | GTK_CSS_AFFECTS_BORDER, border_corner_radius_value_parse, - _gtk_css_number_value_new (0, GTK_CSS_PX)); + _gtk_css_corner_value_new (_gtk_css_number_value_new (0, GTK_CSS_PX), + _gtk_css_number_value_new (0, GTK_CSS_PX))); gtk_css_style_property_register ("border-bottom-right-radius", GTK_CSS_PROPERTY_BORDER_BOTTOM_RIGHT_RADIUS, GTK_STYLE_PROPERTY_ANIMATED, GTK_CSS_AFFECTS_BACKGROUND | GTK_CSS_AFFECTS_BORDER, border_corner_radius_value_parse, - _gtk_css_number_value_new (0, GTK_CSS_PX)); + _gtk_css_corner_value_new (_gtk_css_number_value_new (0, GTK_CSS_PX), + _gtk_css_number_value_new (0, GTK_CSS_PX))); gtk_css_style_property_register ("border-bottom-left-radius", GTK_CSS_PROPERTY_BORDER_BOTTOM_LEFT_RADIUS, GTK_STYLE_PROPERTY_ANIMATED, GTK_CSS_AFFECTS_BACKGROUND | GTK_CSS_AFFECTS_BORDER, border_corner_radius_value_parse, - _gtk_css_number_value_new (0, GTK_CSS_PX)); + _gtk_css_corner_value_new (_gtk_css_number_value_new (0, GTK_CSS_PX), + _gtk_css_number_value_new (0, GTK_CSS_PX))); gtk_css_style_property_register ("outline-style", GTK_CSS_PROPERTY_OUTLINE_STYLE, @@ -1133,7 +1137,6 @@ _gtk_css_style_property_init_properties (void) GTK_CSS_AFFECTS_OUTLINE, outline_parse, _gtk_css_number_value_new (0.0, GTK_CSS_PX)); - gtk_css_style_property_register ("background-clip", GTK_CSS_PROPERTY_BACKGROUND_CLIP, 0, -- 2.30.2