From 9761bfb9b7582ef50202f3b4e04d658713422c0d Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roger=20Pau=20Monn=C3=A9?= Date: Mon, 18 Jan 2016 14:52:31 +0100 Subject: [PATCH] x86/hvm: don't set the BSP as initialised in hvm_vcpu_initialise MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The BSP will be marked as initialised after hvm_load_cpu_ctxt has loaded the initial state, which is called from the toolstack during domain creation. Previous to my HVMlite series HVM guests were started without setting any explicit CPU state (in fact we placed that horrible jmp at 0x0, because the IP was by default set to 0x0). This is no longer true, and now HVM guests require that a proper CPU context is loaded before starting. This change helps enforce this policy. Signed-off-by: Roger Pau Monné --- xen/arch/x86/hvm/hvm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index a99edc2392..f646c1ee7b 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -2487,10 +2487,6 @@ int hvm_vcpu_initialise(struct vcpu *v) /* Init guest TSC to start from zero. */ hvm_set_guest_tsc(v, 0); - - /* Can start up without SIPI-SIPI or setvcpucontext domctl. */ - v->is_initialised = 1; - clear_bit(_VPF_down, &v->pause_flags); } return 0; -- 2.30.2