From 93713f444b3f29d6848527506db69cf78976b32d Mon Sep 17 00:00:00 2001 From: Oleksandr Andrushchenko Date: Fri, 20 Aug 2021 16:18:12 +0200 Subject: [PATCH] ns16550: properly gate Exar PCIe UART cards support Arm is about to get PCI passthrough support which means CONFIG_HAS_PCI will be enabled, so this code will fail as Arm doesn't have ns16550 PCI support: ns16550.c:313:5: error: implicit declaration of function 'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration] 313 | enable_exar_enhanced_bits(uart); | ^~~~~~~~~~~~~~~~~~~~~~~~~ Fix this by gating Exar PCIe UART cards support with the above in mind. Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Jan Beulich --- xen/drivers/char/ns16550.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index b777c8711e..e2c24082c3 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -308,7 +308,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart) /* Handle the DesignWare 8250 'busy-detect' quirk. */ handle_dw_usr_busy_quirk(uart); -#ifdef CONFIG_HAS_PCI +#ifdef NS16550_PCI /* Enable Exar "Enhanced function bits" */ enable_exar_enhanced_bits(uart); #endif -- 2.30.2