From 9231a39f91fad1cf910700df28d4da5a57d98b1b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sandro=20Knau=C3=9F?= Date: Fri, 1 Apr 2022 21:09:51 +0100 Subject: [PATCH] Make KPimGAPI dependency optional Origin: Debian Last-Update: 2018-10-08 Last-Update: 2018-10-08 Gbp-Pq: Name make_libgapi_optional.patch --- CMakeLists.txt | 6 +++++- src/kmailtransport/plugins/smtp/CMakeLists.txt | 5 +++++ src/kmailtransport/plugins/smtp/autotests/CMakeLists.txt | 7 ++++++- src/kmailtransport/plugins/smtp/smtpjob.cpp | 8 ++++++++ src/kmailtransport/plugins/smtp/smtpjob.h | 4 ++++ 5 files changed, 28 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b96dd0b..93e6599 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -53,7 +53,7 @@ find_package(KF5Mime ${KMIME_LIB_VERSION} CONFIG REQUIRED) find_package(KF5Akonadi ${AKONADI_LIB_VERSION} CONFIG REQUIRED) find_package(KF5AkonadiMime ${AKONADIMIME_LIB_VERSION} CONFIG REQUIRED) find_package(KPimSMTP ${KSMTP_LIB_VERSION} CONFIG REQUIRED) -find_package(KPimGAPI ${KGAPI_LIB_VERSION} CONFIG REQUIRED) +find_package(KPimGAPI ${KGAPI_LIB_VERSION} CONFIG) #it will replace kwallet support find_package(Qt5Keychain CONFIG) @@ -65,6 +65,10 @@ set_package_properties(Qt5Keychain PROPERTIES add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050f02) add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055800) +if(KPimGAPI_FOUND) + add_definitions(-DWITH_GAPI) +endif(KPimGAPI_FOUND) + if(BUILD_TESTING) find_package(Qt5Test CONFIG REQUIRED) add_definitions(-DBUILD_TESTING) diff --git a/src/kmailtransport/plugins/smtp/CMakeLists.txt b/src/kmailtransport/plugins/smtp/CMakeLists.txt index cc63d8c..b338a6e 100644 --- a/src/kmailtransport/plugins/smtp/CMakeLists.txt +++ b/src/kmailtransport/plugins/smtp/CMakeLists.txt @@ -32,5 +32,10 @@ target_link_libraries(mailtransport_smtpplugin KF5::ConfigWidgets KF5::KIOWidgets KPim::SMTP + ) + +if(KPimGAPI_FOUND) +target_link_libraries(mailtransport_smtpplugin KPim::GAPICore ) +endif(KPimGAPI_FOUND) diff --git a/src/kmailtransport/plugins/smtp/autotests/CMakeLists.txt b/src/kmailtransport/plugins/smtp/autotests/CMakeLists.txt index 6e5f2b5..9a418ad 100644 --- a/src/kmailtransport/plugins/smtp/autotests/CMakeLists.txt +++ b/src/kmailtransport/plugins/smtp/autotests/CMakeLists.txt @@ -13,6 +13,11 @@ ecm_add_test(smtpjobtest.cpp KF5::ConfigWidgets KF5::KIOWidgets KPim::SMTP - KPim::GAPICore TEST_NAME smtpjobtest ) + +if(KPimGAPI_FOUND) +target_link_libraries(smtpjobtest + KPim::GAPICore + ) +endif(KPimGAPI_FOUND) diff --git a/src/kmailtransport/plugins/smtp/smtpjob.cpp b/src/kmailtransport/plugins/smtp/smtpjob.cpp index 9d565af..9cc5195 100644 --- a/src/kmailtransport/plugins/smtp/smtpjob.cpp +++ b/src/kmailtransport/plugins/smtp/smtpjob.cpp @@ -24,9 +24,11 @@ #include #include +#ifdef WITH_GAPI #include #include #include +#endif #define GOOGLE_API_KEY QStringLiteral("554041944266.apps.googleusercontent.com") #define GOOGLE_API_SECRET QStringLiteral("mdT1DjzohxN3npUUzkENT0gO") @@ -187,6 +189,7 @@ void SmtpJob::startPasswordRetrieval(bool forceRefresh) return; } +#ifdef WITH_GAPI if (transport()->authenticationType() == TransportBase::EnumAuthenticationType::XOAUTH2) { auto promise = KGAPI2::AccountManager::instance()->findAccount(GOOGLE_API_KEY, transport()->userName(), {KGAPI2::Account::mailScopeUrl()}); connect(promise, &KGAPI2::AccountPromise::finished, this, [forceRefresh, this](KGAPI2::AccountPromise *promise) { @@ -208,8 +211,12 @@ void SmtpJob::startPasswordRetrieval(bool forceRefresh) } else { startLoginJob(); } +#else + startLoginJob(); +#endif } +#ifdef WITH_GAPI void SmtpJob::onTokenRequestFinished(KGAPI2::AccountPromise *promise) { if (promise->hasError()) { @@ -225,6 +232,7 @@ void SmtpJob::onTokenRequestFinished(KGAPI2::AccountPromise *promise) transport()->setPassword(tokens); startLoginJob(); } +#endif void SmtpJob::startLoginJob() { diff --git a/src/kmailtransport/plugins/smtp/smtpjob.h b/src/kmailtransport/plugins/smtp/smtpjob.h index 6c98605..bed51f8 100644 --- a/src/kmailtransport/plugins/smtp/smtpjob.h +++ b/src/kmailtransport/plugins/smtp/smtpjob.h @@ -20,10 +20,12 @@ class Job; class Slave; } +#ifdef WITH_GAPI namespace KGAPI2 { class AccountPromise; } +#endif class SmtpJobPrivate; @@ -65,7 +67,9 @@ protected Q_SLOTS: private: void startPasswordRetrieval(bool forceRefresh = false); +#ifdef WITH_GAPI void onTokenRequestFinished(KGAPI2::AccountPromise *result); +#endif void startSmtpJob(); void startLoginJob(); void startSendJob(); -- 2.30.2