From 9131a68ec4216e24b19cdfbbcffc089b85bb1674 Mon Sep 17 00:00:00 2001 From: Kevin Ottens Date: Thu, 26 Nov 2020 19:08:17 +0100 Subject: [PATCH] Get DatabaseErrorTest to pass The E2EE code path would get the engine to go wrong in case of db error. It's just better to have a failing upload or failing mkdir later in those cases. Emitting signals from a ctor is a bad idea anyway Signed-off-by: Kevin Ottens --- src/libsync/propagateremotemkdir.cpp | 1 - src/libsync/propagateupload.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/src/libsync/propagateremotemkdir.cpp b/src/libsync/propagateremotemkdir.cpp index d2fd73700..d1ac78aef 100644 --- a/src/libsync/propagateremotemkdir.cpp +++ b/src/libsync/propagateremotemkdir.cpp @@ -49,7 +49,6 @@ PropagateRemoteMkdir::PropagateRemoteMkdir(OwncloudPropagator *propagator, const SyncJournalFileRecord parentRec; bool ok = propagator->_journal->getFileRecord(parentPath, &parentRec); if (!ok) { - done(SyncFileItem::NormalError); return; } diff --git a/src/libsync/propagateupload.cpp b/src/libsync/propagateupload.cpp index dd67be3ae..7211f4fba 100644 --- a/src/libsync/propagateupload.cpp +++ b/src/libsync/propagateupload.cpp @@ -189,7 +189,6 @@ PropagateUploadFileCommon::PropagateUploadFileCommon(OwncloudPropagator *propaga SyncJournalFileRecord parentRec; bool ok = propagator->_journal->getFileRecord(parentPath, &parentRec); if (!ok) { - done(SyncFileItem::NormalError); return; } -- 2.30.2