From 902dfd33da08169f08a593a4ef2c45d825cca8c8 Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Wed, 12 Nov 2014 10:39:31 +0000 Subject: [PATCH] libxl: add missing action in DEFINE_DEVICE_ADD ... otherwise when device add operation fails, the error message looks like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null) device", which is not very helpful. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Acked-by: Ian Campbell --- tools/libxl/libxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index f7961f608a..de23fec44a 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1) \ GCNEW(aodev); \ libxl__prepare_ao_device(ao, aodev); \ + aodev->action = LIBXL__DEVICE_ACTION_ADD; \ aodev->callback = device_addrm_aocomplete; \ aodev->update_json = true; \ libxl__device_##type##_add(egc, domid, type, aodev); \ -- 2.30.2