From 8d255609930bed04c6436974bd895be9a405d0c1 Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Fri, 2 Oct 2020 12:20:44 +0100 Subject: [PATCH] x86/hvm: Correct error message in check_segment() The error message is wrong (given AMD's older interpretation of what a NUL segment should contain, attribute wise), and actively unhelpful because you only get it in response to a hypercall where the one piece of information you cannot provide is the segment selector. Fix the message to talk about segment attributes, rather than the selector. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- xen/arch/x86/hvm/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/domain.c b/xen/arch/x86/hvm/domain.c index 0ce132b308..10e30175a1 100644 --- a/xen/arch/x86/hvm/domain.c +++ b/xen/arch/x86/hvm/domain.c @@ -39,7 +39,7 @@ static int check_segment(struct segment_register *reg, enum x86_segment seg) { if ( seg != x86_seg_ds && seg != x86_seg_es ) { - gprintk(XENLOG_ERR, "Null selector provided for CS, SS or TR\n"); + gprintk(XENLOG_ERR, "Null segment attributes for CS, SS or TR\n"); return -EINVAL; } return 0; -- 2.30.2