From 87a067fd8f4d4f7c6be02c3d38145115ac542017 Mon Sep 17 00:00:00 2001 From: Juergen Gross Date: Fri, 19 Feb 2021 15:13:37 +0100 Subject: [PATCH] tools/libs/light: fix xl save -c handling MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit libxl_domain_resume() won't work correctly for the case it was called due to a "xl save -c" command, i.e. to continue the suspended domain. The information to do that is not saved in libxl__dm_resume_state for non-HVM domains. Fixes: 6298f0eb8f443 ("libxl: Re-introduce libxl__domain_resume") Reported-by: Marek Marczykowski-Górecki Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Tested-by: Marek Marczykowski-Górecki Acked-by: Wei Liu --- tools/libs/light/libxl_dom_suspend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_dom_suspend.c b/tools/libs/light/libxl_dom_suspend.c index 25d1571895..f7823bbc8f 100644 --- a/tools/libs/light/libxl_dom_suspend.c +++ b/tools/libs/light/libxl_dom_suspend.c @@ -630,12 +630,13 @@ void libxl__domain_resume(libxl__egc *egc, goto out; } + dmrs->suspend_cancel = suspend_cancel; + if (type != LIBXL_DOMAIN_TYPE_HVM) { rc = 0; goto out; } - dmrs->suspend_cancel = suspend_cancel; dmrs->dm_resumed_callback = domain_resume_done; libxl__dm_resume(egc, dmrs); /* must be last */ return; -- 2.30.2