From 8706d38479218dcf549a94516918c3e3b30a7bb0 Mon Sep 17 00:00:00 2001 From: Will Abele Date: Tue, 9 Jul 2019 13:22:23 +0000 Subject: [PATCH] xen/arm: use correct device tree root node name The root node of a device tree should not have a node name. This is specified in section 2.2.1 of version 0.2 of the device tree specification, available from devicetree.org. Linux Kernel versions prior to 4.15 misinterpret flattened device trees with a "/" as the name of the root node as an FDT version older than 16. Linux then fails to parse the FDT. Signed-off-by: Will Abele Reviewed-by: Julien Grall --- xen/arch/arm/acpi/domain_build.c | 2 +- xen/arch/arm/domain_build.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c index 5aae32ac20..1b1cfabb00 100644 --- a/xen/arch/arm/acpi/domain_build.c +++ b/xen/arch/arm/acpi/domain_build.c @@ -145,7 +145,7 @@ static int __init create_acpi_dtb(struct kernel_info *kinfo, if ( ret < 0 ) goto err; - ret = fdt_begin_node(kinfo->fdt, "/"); + ret = fdt_begin_node(kinfo->fdt, ""); if ( ret < 0 ) goto err; diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 16ce5222ca..c1981836a6 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1715,7 +1715,7 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) if ( ret < 0 ) goto err; - ret = fdt_begin_node(kinfo->fdt, "/"); + ret = fdt_begin_node(kinfo->fdt, ""); if ( ret < 0 ) goto err; -- 2.30.2