From 85e4fe9a81a868c1b69d29b6b0d08286081a37fd Mon Sep 17 00:00:00 2001 From: Ansgar Burchardt Date: Mon, 25 Dec 2023 23:40:36 +0100 Subject: [PATCH] [PATCH] fix: use values that are representable as double in test MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit From f61fb0dbc9b41b2661a3b481a056fd006a238495 Mon Sep 17 00:00:00 2001 Origin: vendor, https://gitlab.dune-project.org/core/dune-common/-/merge_requests/1327 Values like 0.1 are not representable as a double which can result in problems, for example: ``` [...]/dune/common/test/hybridutilitiestest.cc:114:43: error: static assertion failed: Wrong compile time sum! 114 | static_assert(sum(numberTupleConstexpr) == 5.1, "Wrong compile time sum!"); | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ [...]/dune/common/test/hybridutilitiestest.cc:114:43: note: the comparison reduces to ‘(5.09999999999999964473e+0l == 5.09999999999999999991e+0l)’ ``` with [gcc 13.2.0 on i386][1]. [1]: https://buildd.debian.org/status/fetch.php?pkg=dune-common&arch=i386&ver=2.9.0-4&stamp=1703267709&raw=0 Gbp-Pq: Name 0001-fix-use-values-that-are-representable-as-double-in-t.patch --- dune/common/test/hybridutilitiestest.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dune/common/test/hybridutilitiestest.cc b/dune/common/test/hybridutilitiestest.cc index 6ab0012..d2f8763 100644 --- a/dune/common/test/hybridutilitiestest.cc +++ b/dune/common/test/hybridutilitiestest.cc @@ -110,8 +110,8 @@ int main() // Compile time checks static_assert(sum(values) == (30*29)/2, "Wrong compile time sum!"); - constexpr auto numberTupleConstexpr = Dune::makeTupleVector(0.1, 2, 3); - static_assert(sum(numberTupleConstexpr) == 5.1, "Wrong compile time sum!"); + constexpr auto numberTupleConstexpr = Dune::makeTupleVector(0.25, 2, 3); + static_assert(sum(numberTupleConstexpr) == 5.25, "Wrong compile time sum!"); return test.exit(); } -- 2.30.2