From 836fdacda99fca89c7455698d028dcf720a5aa42 Mon Sep 17 00:00:00 2001 From: Eh2406 Date: Fri, 23 Feb 2018 23:06:10 -0500 Subject: [PATCH] use entry to not hash twice thanks clippy (cherry picked from commit de9a7b9) --- src/cargo/ops/cargo_read_manifest.rs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/cargo/ops/cargo_read_manifest.rs b/src/cargo/ops/cargo_read_manifest.rs index 48c2d9dab..13ce7affd 100644 --- a/src/cargo/ops/cargo_read_manifest.rs +++ b/src/cargo/ops/cargo_read_manifest.rs @@ -138,11 +138,13 @@ fn read_nested_packages(path: &Path, let pkg = Package::new(manifest, &manifest_path); let pkg_id = pkg.package_id().clone(); - if !all_packages.contains_key(&pkg_id) { - all_packages.insert(pkg_id, pkg); - } else { - info!("skipping nested package `{}` found at `{}`", - pkg.name(), path.to_string_lossy()); + use ::std::collections::hash_map::Entry; + match all_packages.entry(pkg_id) { + Entry::Vacant(v) => { v.insert(pkg); }, + Entry::Occupied(_) => { + info!("skipping nested package `{}` found at `{}`", + pkg.name(), path.to_string_lossy()); + } } // Registry sources are not allowed to have `path=` dependencies because -- 2.30.2