From 811a4036cb1e177f2cb64ec39e90b7564a493634 Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Thu, 11 May 2023 20:13:39 +0800 Subject: [PATCH] Don't bother creating a unique ptr for computeChecksum as we never use the guarded ptr --- src/libsync/bulkpropagatorjob.cpp | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/libsync/bulkpropagatorjob.cpp b/src/libsync/bulkpropagatorjob.cpp index dab9f9846..450d09e9c 100644 --- a/src/libsync/bulkpropagatorjob.cpp +++ b/src/libsync/bulkpropagatorjob.cpp @@ -260,20 +260,16 @@ void BulkPropagatorJob::slotComputeTransmissionChecksum(SyncFileItemPtr item, UploadFileInfo fileToUpload) { // Compute the transmission checksum. - auto computeChecksum = std::make_unique(this); - if (uploadChecksumEnabled()) { - computeChecksum->setChecksumType("MD5" /*propagator()->account()->capabilities().uploadChecksumType()*/); - } else { - computeChecksum->setChecksumType(QByteArray()); - } + const auto computeChecksum = new ComputeChecksum(this); + const auto checksumType = uploadChecksumEnabled() ? "MD5" : ""; + computeChecksum->setChecksumType(checksumType); - connect(computeChecksum.get(), &ComputeChecksum::done, - this, [this, item, fileToUpload] (const QByteArray &contentChecksumType, const QByteArray &contentChecksum) { + connect(computeChecksum, &ComputeChecksum::done, this, [this, item, fileToUpload] (const QByteArray &contentChecksumType, const QByteArray &contentChecksum) { slotStartUpload(item, fileToUpload, contentChecksumType, contentChecksum); }); - connect(computeChecksum.get(), &ComputeChecksum::done, - computeChecksum.get(), &QObject::deleteLater); - computeChecksum.release()->start(fileToUpload._path); + connect(computeChecksum, &ComputeChecksum::done, computeChecksum, &QObject::deleteLater); + + computeChecksum->start(fileToUpload._path); } void BulkPropagatorJob::slotStartUpload(SyncFileItemPtr item, -- 2.30.2