From 80a7d04f532ddc3500acd7988917708a536ae15f Mon Sep 17 00:00:00 2001 From: Paul Durrant Date: Wed, 22 Feb 2017 13:27:34 +0000 Subject: [PATCH] tools/libxenctrl: fix error check after opening libxenforeignmemory Checking the value of xch->xcall is clearly incorrect. The code should be checking xch->fmem (i.e. the return of the previously called function). Signed-off-by: Paul Durrant Acked-by: Wei Liu Acked-by: Ian Jackson --- tools/libxc/xc_private.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/libxc/xc_private.c b/tools/libxc/xc_private.c index f0e089c704..9df69253f5 100644 --- a/tools/libxc/xc_private.c +++ b/tools/libxc/xc_private.c @@ -64,8 +64,7 @@ struct xc_interface_core *xc_interface_open(xentoollog_logger *logger, goto err; xch->fmem = xenforeignmemory_open(xch->error_handler, 0); - - if ( xch->xcall == NULL ) + if ( xch->fmem == NULL ) goto err; return xch; -- 2.30.2