From 7ba271145bd87169d65172e0a42fbf5d56320b4c Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Fri, 14 Jul 2017 15:27:26 +0000 Subject: [PATCH] x86/cpuid: Fix up stale comments * There is no legacy path any more. All static information is retrieved in the first pass. * d->arch.cpuids[] doesn't exist any more. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- xen/arch/x86/cpuid.c | 2 +- xen/arch/x86/domctl.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index beee47d0ed..eca1a9a55b 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -701,7 +701,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, * First pass: * - Perform max_leaf/subleaf calculations. Out-of-range leaves return * all zeros, following the AMD model. - * - Fill in *res for leaves no longer handled on the legacy path. + * - Fill in *res with static data. * - Dispatch the virtualised leaves to their respective handlers. */ switch ( leaf ) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 8fbbf3aeb3..105a576cd8 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -56,9 +56,8 @@ static int update_domain_cpuid_info(struct domain *d, bool call_policy_changed = false; /* Avoid for_each_vcpu() unnecessarily */ /* - * Skip update for leaves we don't care about. This avoids the overhead - * of recalculate_cpuid_policy() and making d->arch.cpuids[] needlessly - * longer to search. + * Skip update for leaves we don't care about, to avoid the overhead of + * recalculate_cpuid_policy(). */ switch ( ctl->input[0] ) { -- 2.30.2