From 78688ffa7e86e7cdb57d383e213fd822aaaa5438 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Tue, 4 Jan 2022 10:20:15 +0100 Subject: [PATCH] libxc: avoid clobbering errno in xc_domain_pod_target() do_memory_op() supplies return value and has "errno" set the usual way. Don't overwrite "errno" with 1 (aka EPERM on at least Linux). There's also no reason to overwrite "err". Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Reviewed-by: Bertrand Marquis --- tools/libs/ctrl/xc_domain.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c index 20b86d986c..ef62f66009 100644 --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -1230,13 +1230,9 @@ static int xc_domain_pod_target(xc_interface *xch, err = do_memory_op(xch, op, &pod_target, sizeof(pod_target)); if ( err < 0 ) - { DPRINTF("Failed %s_pod_target dom %d\n", (op==XENMEM_set_pod_target)?"set":"get", domid); - errno = -err; - err = -1; - } else err = 0; -- 2.30.2