From 7715583b14ba9d645a02f422ee2344ed142f5fad Mon Sep 17 00:00:00 2001 From: Hannah von Reth Date: Tue, 19 Jan 2021 14:28:51 +0100 Subject: [PATCH] Correctly use indexOf --- src/common/checksums.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/common/checksums.cpp b/src/common/checksums.cpp index c6857e549..0c016ef4d 100644 --- a/src/common/checksums.cpp +++ b/src/common/checksums.cpp @@ -144,6 +144,9 @@ QByteArray makeChecksumHeader(const QByteArray &checksumType, const QByteArray & QByteArray findBestChecksum(const QByteArray &_checksums) { + if (_checksums.isEmpty()) { + return {}; + } const auto checksums = QString::fromUtf8(_checksums); int i = 0; // The order of the searches here defines the preference ordering. @@ -162,7 +165,7 @@ QByteArray findBestChecksum(const QByteArray &_checksums) return _checksums.mid(i, end - i); } qCWarning(lcChecksums) << "Failed to parse" << _checksums; - return QByteArray(); + return {}; } bool parseChecksumHeader(const QByteArray &header, QByteArray *type, QByteArray *checksum) -- 2.30.2